artoolkitx / arunityx

artoolkitX for Unity, providing high-performance video acquisition, marker and texture tracking and full Unity Editor support
https://www.artoolkitx.org/
Other
41 stars 22 forks source link

Consider making the Unity package UPM compatible #41

Closed SimonDarksideJ closed 11 months ago

SimonDarksideJ commented 1 year ago

The modern way of deploying packages in Unity is via UPM (Unity Package Manager).

Consider updating the Unity package repository to match the UPM project layout, rather than making a .UnityPackage export, which is safer and provides versioning (plus allows publishing to OpenUPM)

https://docs.unity3d.com/Manual/cus-layout.html

A good example is the RealityCollective packages which have automation to manage building/testing and tagging for OpenUPM https://github.com/realitycollective/com.realitycollective.service-framework

philip-lamb commented 1 year ago

Sounds good Simon. Looking into it.

ryohey commented 11 months ago

Just for your reference, if you're not already aware, I think you are trying a big directory structure change in the upm branch, but you can specify the path in manifest.json as follows, so you may just need to add the Plugins binary to your current master branch. I hope this helps.

"org.artoolkitx.artoolkitx-unity": "https://github.com/artoolkitx/arunityx.git?path=Packages/artoolkitX-Unity"
philip-lamb commented 11 months ago

@ryohey Thanks, and yes was aware of it but decided to follow the subtree-split UPM strategy, since this is slightly cleaner for the users who are not interested in developing the toolkit itself.

Thanks for taking an interest in the project, good to see our community growing!

philip-lamb commented 11 months ago

Closed in https://github.com/artoolkitx/arunityx/pull/87