support console events - Githubissues

artprima / prometheus-metrics-bundle

Symfony 5/6 Prometheus Metrics Bundle

MIT License

129 stars 29 forks source link

support console events #44

Closed ctrl-f5 closed 3 years ago

ctrl-f5 commented 3 years ago

currently there are only collectors for kernel.terminate. this however does not work for console commands, since that dispatches the ConsoleTerminateEvent

this prevents us from providing metrics for things like Symfony/Messenger workers: number of messages processed/failed etc.

denisvmedia commented 3 years ago

Thank you for your PR. It makes sense. Can you please change the destination branch to develop?

ctrl-f5 commented 3 years ago

sure thing, PR to develop!

denisvmedia commented 3 years ago

Merged. Will be released soon. Thank you for your efforts.