artprima / prometheus-metrics-bundle

Symfony 5/6 Prometheus Metrics Bundle
MIT License
133 stars 29 forks source link

interfaces and event listeners for console terminate and error #45

Closed ctrl-f5 closed 3 years ago

ctrl-f5 commented 3 years ago

allow to hook into console.terminate and console.error for metric collection.

solves #44

codecov-commenter commented 3 years ago

Codecov Report

Merging #45 (1945b81) into develop (ea20de3) will decrease coverage by 2.54329%. The diff coverage is 40.00000%.

Impacted file tree graph

@@                  Coverage Diff                  @@
##               develop         #45         +/-   ##
=====================================================
- Coverage     79.16667%   76.62338%   -2.54328%     
- Complexity          86          96         +10     
=====================================================
  Files               12          12                 
  Lines              288         308         +20     
=====================================================
+ Hits               228         236          +8     
- Misses              60          72         +12     
Impacted Files Coverage Δ Complexity Δ
EventListener/MetricsCollectorListener.php 45.45455% <40.00000%> (-1.38089%) 45.00000 <10.00000> (+10.00000) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ea20de3...1945b81. Read the comment docs.

denisvmedia commented 3 years ago

Thanks. Could you please fix the conflicts?