search

artprima / prometheus-metrics-bundle

Symfony 5/6 Prometheus Metrics Bundle
MIT License
133 stars 29 forks source link

GetResponseEvent => RequestEvent, PostResponseEvent => TerminateEvent #7

Closed ns3777k closed 4 years ago

ns3777k commented 4 years ago

Closes #5

smatyas commented 4 years ago

Just a note: imho this should have been a major version change (assuming this bundle follows semver), as it breaks the API. This is why it is only marked as deprecated in symfony, but not removed. They will remove it in the next major release.

denisvmedia commented 4 years ago

Well, it depends on how you interpret what the specification says. My bundle is not changing its API, so from this prospective it's not a backwards incompatible change. However, it's true that such changes are not compatible with the old versions of Symfony. Yet, there is composer.json and I changed it accordingly, so that unless you upgrade your Symfony components, you can't use the newer version of this bundle. And considering I didn't introduce anything major in this bundle, I decided to just increment the minor version of the distribution.

smatyas commented 4 years ago

My bundle is not changing its API

Well, it did, because you just modified the Metrics/MetricsGeneratorInterface.php which we implemented, and this very change broke our implementation this way :)

Not a big deal though, just a thing to keep in mind in future cases like this.

Thanks for the heads-up!