artprima / prometheus-metrics-bundle

Symfony 5/6 Prometheus Metrics Bundle
MIT License
133 stars 29 forks source link

Fix deprecation in ClearMetricsCommand #83

Closed alshenetsky closed 1 year ago

alshenetsky commented 1 year ago

since Symfony 6.1:

The "Symfony\Component\Console\Command\Command::$defaultName" property is considered final. You should not override it in "Artprima\PrometheusMetricsBundle\Command\ClearMetricsCommand".

codecov-commenter commented 1 year ago

Codecov Report

Base: 85.20085% // Head: 85.23207% // Increases project coverage by +0.03122% :tada:

Coverage data is based on head (2513098) compared to base (ff351e8). Patch coverage: 100.00000% of modified lines in pull request are covered.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #83 +/- ## ===================================================== + Coverage 85.20085% 85.23207% +0.03122% Complexity 137 137 ===================================================== Files 18 18 Lines 473 474 +1 ===================================================== + Hits 403 404 +1 Misses 70 70 ``` | [Impacted Files](https://codecov.io/gh/artprima/prometheus-metrics-bundle/pull/83?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=artprima) | Coverage Δ | | |---|---|---| | [Command/ClearMetricsCommand.php](https://codecov.io/gh/artprima/prometheus-metrics-bundle/pull/83?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=artprima#diff-Q29tbWFuZC9DbGVhck1ldHJpY3NDb21tYW5kLnBocA==) | `100.00000% <100.00000%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=artprima). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=artprima)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

denisvmedia commented 1 year ago

Thank you @alshenetsky!