artprojectgroup / woocommerce-apg-sms-notifications

WC – APG SMS Notifications
https://artprojectgroup.es/plugins-para-woocommerce/wc-apg-sms-notifications
Other
6 stars 9 forks source link

[Issue] Bug in RBSOFT SMS Gateway: SMS Not Sent When Country Code is NULL #14

Open N-harzallah opened 6 months ago

N-harzallah commented 6 months ago

I have identified a bug in the RBSOFT SMS Gateway where SMS messages are not being sent to the API when the country code is NULL in the database. This issue becomes apparent when using themes that do not store the country code in the database, especially on orders placed through forms that do not display or store country information due to theme restrictions.

Steps to Reproduce : Use a theme that restricts or does not display country information in the order form. Or remove country code from an order on database and try to change status of order Observe that the SMS is not sent to the API.

Expected Behavior :

The SMS should be sent to the API even when the country code is NULL in the database if sms gateway require + and country code, retrieve default country code from woocommerce store

Additional Information :

WordPress Version: Latest Plugin Version: Latest WooCommerce Version: latest

Thank you for your prompt attention to this matter. If you require any further information or clarification, please feel free to ask.

artprojectgroup commented 6 months ago

Sorry but we don't have support for that provider in the plugin, also the country field is mandatory in all cases so we don't understand why you don't have it, we do not recommend you to remove or block it. Without that value the plugin will never work because it needs to know the international code associated with a particular country.

Best regards.