search

artprojectgroup / woocommerce-apg-sms-notifications

WC – APG SMS Notifications
https://artprojectgroup.es/plugins-para-woocommerce/wc-apg-sms-notifications
Other
6 stars 9 forks source link

Add new provider: SMSBOX.COM #9

Closed adnanebrahimi closed 3 years ago

adnanebrahimi commented 3 years ago

Add new provider for Kuwaitis number: SMSBOX.COM

artprojectgroup commented 3 years ago

We'll add it as soon as possible.

Kind regards.

artprojectgroup commented 3 years ago

Sorry we don't understand why did you add this: str_replace('','+',$telefono) in recipientNumbers, 'false' in isBlink and isFlash, and ' ' in defDate.

Where's published the full API documentation? Because in https://www.smsbox.com/API/SendShortMessage#class-desc we can't see how to send that fields.

Kind regards.

adnanebrahimi commented 3 years ago

Hello,

The API needs these parameters to be set.

the API didn't allow + as prefix of phone number so I remove it by str_replace('','+',$telefono) Note that this SMS Provider now only can be used for Kuwaiti numbers.

Read More: http://smsbox.com/API/SendShortMessage

artprojectgroup commented 3 years ago

Sorry but we can't add this provider to our plugin if we're not sure that your code has no issues, and we can't know that because the API documentation is too poor and doesn't provide enough information.

Kind regards.

adnanebrahimi commented 3 years ago

I understand your concern.

How can I make you sure about this Provider? Do you need any official request from them?

artprojectgroup commented 3 years ago

No, we need the full code without issues.

Kind regards.