artscout / MikScrollingBattleText

Fix for TBC classic
26 stars 3 forks source link

Fix for incorrect display and lua errors in notifications #13

Open LaryIsland opened 1 year ago

LaryIsland commented 1 year ago

Scrolling down the notification events category will cause lua error spam, as well as not properly displaying the options.

Removing the following lines from MSBTOptionsTabs.lua fixes the issue:

EventsTab_AddEvent(category, "NOTIFICATION_CHI_CHANGE", c.CHI_AMOUNT)
EventsTab_AddEvent(category, "NOTIFICATION_CHI_FULL", c.CHI_AMOUNT)
EventsTab_AddEvent(category, "NOTIFICATION_AC_CHANGE", c.AC_AMOUNT)
EventsTab_AddEvent(category, "NOTIFICATION_AC_FULL", c.AC_AMOUNT)

EventsTab_AddEvent(category, "NOTIFICATION_HOLY_POWER_CHANGE", c.HOLY_POWER_AMOUNT)
EventsTab_AddEvent(category, "NOTIFICATION_HOLY_POWER_FULL", c.HOLY_POWER_AMOUNT)
EventsTab_AddEvent(category, "NOTIFICATION_ESSENCE_CHANGE", c.ESSENCE_AMOUNT)
EventsTab_AddEvent(category, "NOTIFICATION_ESSENCE_FULL", c.ESSENCE_AMOUNT)

These options are also not necessary given that holy power, arcane charges, chi, and essence didn't exist in WotLK