artseyio / legacy-artsey-qmk

(Legacy) QMK Files for ARTSEY
https://github.com/artseyio/qmk-artsey
13 stars 9 forks source link

Unable to compile #6

Open BW155 opened 3 years ago

BW155 commented 3 years ago

Hi, I recently build my own artsey keyboard based on a atmega32u4. I'm now trying to compile a right_hand version of artsey but it doesn't work with the given instructions. I tried it in many ways but the main errors are like keyboards/artsey/keymaps/artsey_right/keymap.c:13:13: error: implicit declaration of function 'LAYOUT'; did you mean 'NAKOUTE'?. Stuff that should be imported.

I noticed some imports appear to be missing of some kind, when I make a new keyboard using the qmk util I see includes like #include QMK_KEYBOARD_H. Which are not in the artsey keymap files.

Could you maybe point out what I'm doing wrong? Or does this repo need to be updated because some breaking change in qmk?

BW155 commented 3 years ago

I got it working already after some more tries. I needed to create a fresh keyboard using the keyboard util util/new_keyboard of qmk_firmware. I used the early_combo branch of sevanteri qmk fork where I created that new keyboard. I dropped the files in from artsey_right and changed the #include keyboard.h in keymap to the h file of my new keyboard (that instruction was missing in the readme) I also needed to change the LAYOUT macro definition in my keyboard h file to fit the 8 keys (got some errors about that one too). I also needed to change the matrix_rows and matrix_cols in config.h.

Maybe you could add the missing instructions and warnings into the readme to make the required steps more clear for 'beginners'.

Merging the above linked repo into the official qmk_firmware repo doesn't work btw. Weird merge activity that causes code corruption. (no conflicts shown though).