artshumrc / giza

JSON API (for TMS Database) and Django 2 application for Digital Giza
http://giza.fas.harvard.edu/
7 stars 5 forks source link

“Download PDF” link? #35

Closed raronin closed 7 years ago

raronin commented 7 years ago

For Bibliography pages, the “download PDF” link needs to be waaaaaaayyyyyyy more obvious (right now it’s only in the full view, at the bottom of the Details section. Ideally, clicking on the thumbnail should open the pdf.)

raronin commented 7 years ago

Something seems to be not working correctly on the Bibliography pages. I think the thumbnails for the PDFs should be showing up (?) but they're not. There's just a weird bar that, if you click on it, downloads the PDF.

rsinghal commented 7 years ago

I need a link or something. I don't know what you are looking at.

raronin commented 7 years ago

http://giza-web.rc.fas.harvard.edu/pubdocs/156/intro/

raronin commented 7 years ago

Also: http://giza-web.rc.fas.harvard.edu/pubdocs/80/intro/ http://giza-web.rc.fas.harvard.edu/pubdocs/109/intro/

rsinghal commented 7 years ago

There is something wrong with those images. They need to be fixed on your end.

raronin commented 7 years ago

I'm not sure what is wrong. They appear fine in TMS. Can you be more specific?

raronin commented 7 years ago

OK, we figured out the problem: some images have "JPEG" rather than "jpeg" as the extension. We will fix these asap.

jkisala commented 7 years ago

I believe I've now replaced all of the .JPGs with .jpg, so these should be fine now!