Open ColeDCrawford opened 3 years ago
MyGiza Collections were discussed in design meetings as necessarily relying on Mirador, so that dependency was expected. Through this initial stage, video media wasn't expected to be in MyGiza Collections. A separate section was designed for them on the Giza@School Lesson Topic pages, i.e. so they could be included in parallel with Collections, rather than as items in the Collections. Once the remaining issue with the Offloader App has been worked out, the tiny number of test IIIF images in the DB will jump to over 65,000.
@lukehollis do you have those designs? Not seeing anything for this in the data model.
@npicardo - just curious, were there any designs for creating Collections? Right now that "+" link drops you into the Django admin interface. That's fine, but may be a bit jarring for end users who haven't seen that before.
Following Nick's email - http://dev.pixelsforhumans.com/giza/mygiza-collection.html# for designs.
I'm seeing a modal for "Add Collection" here which isn't implemented, but no further designs for how to actually add content there through a separate frontend workflow.
Designs for adding images to collections from an image page:
Thanks @npicardo. Were there any designs for adding content from the collection page, or just from an image page?
To be able to view a collection, yes, Mirador is needed. But this could have been built out before, as it's about adding content to the database managed by Django.
The annotations work is separate.
@lukehollis do you need any other info for this? Or can this be moved from backlog to Groomed?
This is related to #87. Right now, the only way an admin or an end user can add items to a collection is by filling in a list of comma-separated IDs in the Django admin interface.
The above designs outline the workflow for adding an item to a collection, as an end user, from the item page.
For an admin, there should be some sort of autocomplete feature to add an item to a collection from the Django admin Collection page. Ideally most of this work could be reused to provide a similar feature for a non-admin user on the frontend Collection page. I don't see a compelling reason that a non-admin user should ever see the Django admin interface.
I agree, the dashboard should be admin only and that public users should not need to see it. It would be impractical to require them to add images via the TMS mastermedia ID, which none will have the know-how to do. For admins using the dashboard, I personally have no problem with the current method of adding media for admins. For public users, the designs always envisioned adding media from the front end via clicks associated with the media themselves. The only other means Heather talked about was the possibility of an "add all images" kind of button on page views displaying multiple images (e.g. media search results?), but I haven't noticed that having made it through to final designs. (Will look again to be sure.)
cheers, Nick
From: Cole Crawford notifications@github.com Sent: Tuesday, December 1, 2020 4:52 PM To: rsinghal/giza giza@noreply.github.com Cc: Picardo, Nicholas npicardo@fas.harvard.edu; Mention mention@noreply.github.com Subject: Re: [rsinghal/giza] Integrate Mirador with Collections (#90)
This is related to #87https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_rsinghal_giza_issues_87&d=DwMCaQ&c=WO-RGvefibhHBZq3fL85hQ&r=DBtE9VsxhV3LTRMIedD72g_uRb7yrPLspnBaM1zWljQ&m=EwUGLryBk2veMh3d5X-OrXkKG5WqYyi9dwdpzVJPU2A&s=qqJl6-De44abWlvQfgS0P_QLEYSN1QfeqDnAcZ0PRJQ&e=. Right now, the only way an admin or an end user can add items to a collection is by filling in a list of comma-separated IDs in the Django admin interface.
The above designs outline the workflow for adding an item to a collection, as an end user, from the item page.
For an admin, there should be some sort of autocomplete feature to add an item to a collection from the Django admin Collection page. Ideally most of this work could be reused to provide a similar feature for a non-admin user on the frontend Collection page. I don't see a compelling reason that a non-admin user should ever see the Django admin interface.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_rsinghal_giza_issues_90-23issuecomment-2D736843355&d=DwMCaQ&c=WO-RGvefibhHBZq3fL85hQ&r=DBtE9VsxhV3LTRMIedD72g_uRb7yrPLspnBaM1zWljQ&m=EwUGLryBk2veMh3d5X-OrXkKG5WqYyi9dwdpzVJPU2A&s=eynpp1_w7rVAk2cxyfVwqJHmQR68JMRzcRzuVYWoQ-w&e=, or unsubscribehttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AF2IPE2HXIXHMRSWNRATOVLSSVQRJANCNFSM4T33L34Q&d=DwMCaQ&c=WO-RGvefibhHBZq3fL85hQ&r=DBtE9VsxhV3LTRMIedD72g_uRb7yrPLspnBaM1zWljQ&m=EwUGLryBk2veMh3d5X-OrXkKG5WqYyi9dwdpzVJPU2A&s=oPWlVrfEV2IjeBdtHsMt5vO89w1rkzYjAzhEf7dh6ok&e=.
Thanks for the clarification, @npicardo. That implementation on the admin side still seems a bit clunky to me, but it's your and Peter's call on how to prioritize tasks. If you have a chance to sort the "Groomed" column so the highest priority cards are at the top, that might help @lukehollis unless you're already communicating with him off-board on which tasks to tackle first.
Whether or not that button was in the designs doesn't really matter at this point because all the pending work for this and the other features is all backend / data model related.
Linking this to #94 as end users should have restricted permissions scoped to edited only their content.
Thanks Cole.
I agree that it's a little clunky on the admin side. In the interest of expedience, I feel as though I've no alternative but to weight the existence of basic functions over optimal convenience of those functions.
Apologies for about designs. Lacking fine-grained knowledge of what does what on the back end, my main fallback is to understand the website in terms of front-end appearance and function.
I'll take a look at the "Groomed" tasks. I'd though only the "To do" list was in need of re-ordering. On it!
cheers, Nick
From: Cole Crawford notifications@github.com Sent: Wednesday, December 2, 2020 10:23 AM To: rsinghal/giza giza@noreply.github.com Cc: Picardo, Nicholas npicardo@fas.harvard.edu; Mention mention@noreply.github.com Subject: Re: [rsinghal/giza] Integrate Mirador with Collections (#90)
Thanks for the clarification, @npicardohttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_npicardo&d=DwMCaQ&c=WO-RGvefibhHBZq3fL85hQ&r=DBtE9VsxhV3LTRMIedD72g_uRb7yrPLspnBaM1zWljQ&m=PcY3IT27T7ucVshZg_-_G5acDw84xduLv-3vi5rlYxY&s=Z8D1ceFH5286VDfC8remAQUHTeWBZWPMKB98i55ourk&e=. That implementation on the admin side still seems a bit clunky to me, but it's your and Peter's call on how to prioritize tasks. If you have a chance to sort the "Groomed" column so the highest priority cards are at the top, that might help @lukehollishttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_lukehollis&d=DwMCaQ&c=WO-RGvefibhHBZq3fL85hQ&r=DBtE9VsxhV3LTRMIedD72g_uRb7yrPLspnBaM1zWljQ&m=PcY3IT27T7ucVshZg_-_G5acDw84xduLv-3vi5rlYxY&s=J390Yf0Y0pYXZOlyc-I2ADcWmz69E9vhDQOHSYZ4rAg&e= unless you're already communicating with him off-board on which tasks to tackle first.
Whether or not that button was in the designs doesn't really matter at this point because all the pending work for this and the other features is all backend / data model related.
Linking this to #94https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_rsinghal_giza_issues_94&d=DwMCaQ&c=WO-RGvefibhHBZq3fL85hQ&r=DBtE9VsxhV3LTRMIedD72g_uRb7yrPLspnBaM1zWljQ&m=PcY3IT27T7ucVshZg_-_G5acDw84xduLv-3vi5rlYxY&s=LlBtrutTyBRIOq3jjmWNXYfiuNj57Srjs_3704Nn6Ms&e= as end users should have restricted permissions scoped to edited only their content.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_rsinghal_giza_issues_90-23issuecomment-2D737299738&d=DwMCaQ&c=WO-RGvefibhHBZq3fL85hQ&r=DBtE9VsxhV3LTRMIedD72g_uRb7yrPLspnBaM1zWljQ&m=PcY3IT27T7ucVshZg_-_G5acDw84xduLv-3vi5rlYxY&s=bFOwUJR52Ahk34WbtVJD94AhkpUqDM3H8FaL4_-q0z8&e=, or unsubscribehttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AF2IPEZCUL36MFTOAEQCL73SSZLYDANCNFSM4T33L34Q&d=DwMCaQ&c=WO-RGvefibhHBZq3fL85hQ&r=DBtE9VsxhV3LTRMIedD72g_uRb7yrPLspnBaM1zWljQ&m=PcY3IT27T7ucVshZg_-_G5acDw84xduLv-3vi5rlYxY&s=_3m6w97XNrtkNlEu42sOzvvWpFjKTx3veQYEziG43VI&e=.
Thanks for updating, @rsinghal -- it sounds like Mirador is a separate issue than what's described with the admin side? Is this now a duplicate of https://github.com/rsinghal/giza/issues/87 ?
I'll probably split these into separate tasks, but getting thoughts down here first.
[ ] We need a way for end users to add items to collections, without visiting the Django admin. Probably a button on the item page as outlined above in the designs.
[ ] We need correctly disambiguated items within a collection scope. I don't know what ID collections is currently searching on, but simply using a list of IDs is inadequate because the IDs are not namespaced. You end up with 3 IDs turning into 5 objects (eg 26830 gets both http://giza-web2.rc.fas.harvard.edu/photos/26830/full/ and http://giza-web2.rc.fas.harvard.edu/objects/26830/full/). See images
[ ] We need to know how mixed-content collections should display. What happens to a collection with a video, an image media record (manifest with 1 canvas), a Site (manifest with 1+ canvases), and another image/Site/Constituent/etc that does not yet have a DRS ID / manifest record? @npicardo above said video shouldn't be in collections, but there is currently nothing to stop a user from adding it there (see photo - I added ID 45695 and that adds both "Western Cemetary: Site: Giza" video and "Fragments of box coffin" object because they both have that ID). We would need to someone prevent people from adding videos in the first place. Also, how do we handle items that don't have DRS IDs yet?
[ ] Once we have a list of the content which can actually be displayed by Mirador, we will need to generate a IIIF Collection (an ordered list of manifests) for the Giza Collection's manifests. This needs to be generated on the fly or re-generated every time the collection is edited. I think as long as the Collection points to manifests rather than embedding them we would not need to regenerate if an item is edited.
[ ] Once we have the above in place, then we can handle integrating Mirador. Adding Mirador is straightforward if all the data is there.
This would require all items in the Collection to have IIIF resources, or a clear understanding of how to handle resources without IIIF resources. How would we handle items without images (eg videos)? Right now, only 20 sample items in ES have IIIF resources attached.