Rotation Docs Updates - Githubissues

artsy / README

:wave: - The documentation for being an Artsy Engineer

Creative Commons Attribution 4.0 International

1.1k stars 120 forks source link

Rotation Docs Updates #464

Closed chr-tatu closed 2 years ago

chr-tatu commented 2 years ago

Changes Summary in sprint-rotation.md

Adding Rotation buddy responsibilities
Removing forced line wraps.
Adding a suggestion to organize 1:1 with different team members
Reducing the heading by 1, since the document only contained Header 2+.

chr-tatu commented 2 years ago

Last I checked, the line-wrapping was enforced by an automatic pre-commit hook. (However, I'm not a fan, so if you can get rid of that, or if I just have an old setup and can be ignored, that would be great.)

It makes sense to me, too. If someone wants a line wrap, it can be defined when viewing the file, not embedded in a file. I checked .git/hooks and there is no commit hook defined for this repo.

lidimayra commented 2 years ago

On the line wrapping topic, it's worth noting that a related discussion also happened here: https://github.com/artsy/potential/issues/443

joeyAghion commented 2 years ago

The git hook (at least in my case) is also responsible for generating tables of contents (and maybe other things). See the precommit command.

I think this could merit some additional work (not related to this PR!), maybe just a setup script that sets up any necessary hooks, excluding the line-breaking.

chr-tatu commented 2 years ago

That's interesting. I didn't know about it. I'll add it to my todo list, @joeyAghion .