artsy / README

:wave: - The documentation for being an Artsy Engineer
Creative Commons Attribution 4.0 International
1.1k stars 120 forks source link

docs: Update rfcs.md #491

Closed patrinoua closed 1 year ago

artsy-peril[bot] commented 1 year ago
Fails
:no_entry_sign: Danger failed to run `peril-downloaded-artsy/peril-settings@org/jira/pr.ts`.

Error TypeError

object null is not iterable (cannot read property Symbol(Symbol.iterator))
TypeError: object null is not iterable (cannot read property Symbol(Symbol.iterator))
    at Function.from (<anonymous>)
    at reverse (peril-downloaded-artsy/peril-settings@/org/jira/utils.ts:39:32)
    at exports.getJiraTicketIDsFromText (peril-downloaded-artsy/peril-settings@/org/jira/utils.ts:10:25)
    at Object.exports.default (peril-downloaded-artsy/peril-settings@org/jira/pr.ts:15:30)
    at processTicksAndRejections (internal/process/task_queues.js:95:5)

Dangerfile

34|   // We know we have something to work with now
35|   const jira: JiraApi.default = new (JiraApi as any)({
36|     protocol: "https",
37|     host: `${companyPrefix}.atlassian.net`,
38|     apiVersion: "2",
----------------------------------^
39|     strictSSL: true,
40|     username: peril.env.JIRA_EMAIL,
41|     password: peril.env.JIRA_ACCESS_TOKEN,
42|   })

Generated by :no_entry_sign: dangerJS against 92b6ba3b339a528ec6bb28aae1730c09f688b800

patrinoua commented 1 year ago

Actually not sure this is the right way to add a new RFC. This is the old way right? Where do we add the new PR when creating an RFC?