search

artsy / artsy.github.io

The Artsy Engineering Open-Source Developers Blog
https://artsy.github.io
MIT License
1.08k stars 227 forks source link

Upgrade jekyll etc. (PLATFORM-4085) #722

Closed joeyAghion closed 2 years ago

joeyAghion commented 2 years ago

This started as an effort to patch kramdown, which required recent jekyll. I said a short prayer and started pulling the thread, performing other necessary updates (octopress-hooks, danger), fixing errors, and then addressing most warnings.

I'll leave a few inline comments about particular choices.) It's mostly working. Locally, code highlighting and search don't operate as expected.

I noticed these past overlapping efforts when prepping this PR:

In particular, your in-progress upgrade included some changes to the BacktickCodeBlock module responsible for highlighting that maybe I should borrow? I'm happy to go in any direction that supports the critical upgrades.

jonallured commented 2 years ago

Yeah I confess to giving up on the blog upgrade I was working on so I'm happy to see you've taken up the task! I absolutely believe we should drop search functionality and not worry about it at all. When it comes to code highlighting I think we do want that to work but I think impact over perfection would nudge me towards mostly being sufficient!