This project has a custom Jekyll plug-in (_plugins/generator_scss.rb) that runs Compass compilation. I'm not sure that's done reliably (as in propagating errors) and synchronously. Only 1 time out of many did my rake build end up with the same broken CSS issue that we saw in production.
Jekyll automatically compiles *.scss files with a different library than compass.
.gitignore listed some of the compiled css/*.css files, so if you built the site, then switched to another branch with broken CSS compilation and rebuilt, those files would still be in the generated site and appear to work fine. (Notably, they wouldn't be there when CI built the site.)
Releases in CircleCI (1, 2, 3, 4) haven't been working as expected. One step is failing at the moment, but others could fail without short-circuiting the build because we don't check the exit status and in some cases suppress the output. I did not fix this fully, but did fix the currently failing step and the suppressed output.
Rather than keep breaking the production blog I set up a fork of the project with CI that's serving this branch's compiled site at https://joeyaghion.github.io/.
This PR retries the upgrades in https://github.com/artsy/artsy.github.io/pull/722, and adds a commit that drops compass in favor of Jekyll's built-in Sass compilation.
See the revert (https://github.com/artsy/artsy.github.io/pull/724) for the problem we encountered.
What I've learned since then:
_plugins/generator_scss.rb) that runs Compass compilation. I'm not sure that's done reliably (as in propagating errors) and synchronously. Only 1 time out of many did myrake buildend up with the same broken CSS issue that we saw in production..gitignorelisted some of the compiledcss/*.cssfiles, so if you built the site, then switched to another branch with broken CSS compilation and rebuilt, those files would still be in the generated site and appear to work fine. (Notably, they wouldn't be there when CI built the site.)Rather than keep breaking the production blog I set up a fork of the project with CI that's serving this branch's compiled site at https://joeyaghion.github.io/.