anandaroop
commented
1 year ago This has all been tested by running the server locally and hitting it from desktop and mobile. Seems good.
We can let this soak for a while in prod (i.e. no rush to merge the blocked work in #750) so that we can back out of this change if something got borked.
This addresses a blocker uncovered in the course of https://github.com/artsy/artsy.github.io/pull/750
I was unable to build some very old site-search-related dependencies, and learned during an Engineering Knowledge Share that I wasn't the only one.
In addition to making it cumbersome to work with the repo locally for ordinary blog post authoring (needing to comment out the problematic gem etc) this also makes it impossible to update the project's gem dependencies for new features such as in the PR above.
Updating the dependencies was a losing battle due to us using a private fork of a library which itself was deprecated years ago 😣
This PR instead takes the expedient route of removing client-side search altogether from the blog, as discussed by some of us during that KS.
It would be great to bring this back in some form whether via a more modern client-side lib, or via Algolia's OSS offering, or something else. That'll be for another #FF.
See the commit list for some fun archaeological findings, like 16c71a05cd3b9c0abc115a4286ce8fda907dff62