artsy / eigen

The Art World in Your Pocket or Your Trendy Tech Company's Tote, Artsy's mobile app.
MIT License
3.54k stars 572 forks source link

feat: update credit card input component #10476

Closed MounirDhahri closed 1 month ago

MounirDhahri commented 1 month ago

[Future Friday]

Description

This PR updates the credit card input component to use the new input component design

https://github.com/user-attachments/assets/e406a996-2a50-4975-b652-99f27aabc4f7

Note: I am hiding the credit card label when the input is focused because - one, we don't have access to the tapable area in the input, so I couldn't make the entire label clickable. 2 - Because we would be intersecting touches, the user might end up having the month/year input activated instead of the number. I know this is not 100% ideal but it's better than what we have now.

PR Checklist

To the reviewers πŸ‘€

Changelog updates ### Changelog updates #### Cross-platform user-facing changes - update credit card input component - mounir #### iOS user-facing changes - #### Android user-facing changes - #### Dev changes -

Need help with something? Have a look at our docs, or get in touch with us.

ArtsyOpenSource commented 1 month ago

This PR contains the following changes: