artsy / eigen

The Art World in Your Pocket or Your Trendy Tech Company's Tote, Artsy's mobile app.
MIT License
3.54k stars 572 forks source link

chore: handle error when saving push notification token #10478

Closed gkartalis closed 1 month ago

gkartalis commented 1 month ago

This PR resolves []

Description

@dariakoko noticed this issue bubbling up in sentry and we decided to add a try catch block and an info level captureMessage to prevent bubbling the error this way and have a less scary error message.

PR Checklist

To the reviewers πŸ‘€

Changelog updates ### Changelog updates #### Cross-platform user-facing changes - #### iOS user-facing changes - #### Android user-facing changes - #### Dev changes - handle error when saving push notification token - darianorge

Need help with something? Have a look at our docs, or get in touch with us.

ArtsyOpenSource commented 1 month ago

This PR contains the following changes:

damassi commented 1 month ago

Yah, I agree with @araujobarret - Send this out via codepush, get some more intel!