fix: 'Frame not included' string showing on all lots

brainbicycle commented 1 month ago

This PR resolves []

Description

Uses forces logic including unlisted to prevent "Frame not included" from showing up on auction lots when this value is not explicitly set.

Before

![before](https://github.com/user-attachments/assets/934b42f0-a2da-4be6-9e1f-5e500b131d39)

After

![after](https://github.com/user-attachments/assets/67cd8f0d-fd44-45bb-9edb-9dcb2133bbba)

PR Checklist

[ ] I have tested my changes on iOS and Android.
[x] I hid my changes behind a feature flag, or they don't need one.
[x] I have included screenshots or videos, or I have not changed the UI.
[x] I have added tests, or my changes don't require any.
[x] I added an app state migration, or my changes do not require one.
[x] I have documented any follow-up work that this PR will require, or it does not require any.
[x] I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

[ ] I would like at least one of the reviewers to run this PR on the simulator or device.

Changelog updates

### Changelog updates #### Cross-platform user-facing changes - Fix 'Frame not included' bug in auction lots - brian #### iOS user-facing changes - #### Android user-facing changes - #### Dev changes -

Need help with something? Have a look at our docs, or get in touch with us.

ArtsyOpenSource commented 1 month ago

This PR contains the following changes:

Cross-platform user-facing changes (Fix 'Frame not included' bug in auction lots - brian)
Generated by :no_entry_sign: dangerJS against 9543c5d6e18ef89f0005b631e4863a1c872f4676

damassi commented 1 month ago

Might be worth updating this test file too: https://github.com/artsy/eigen/blob/123905a5dc94a589d7297ed44d818b87e0a0cc30/src/app/Scenes/Artwork/Components/ArtworkDimensionsClassificationAndAuthenticity/ArtworkDimensionsClassificationAndAuthenticity.tests.tsx

jpotts244 commented 1 month ago

Tested with an unlisted artwork too, looks great!

artsy / eigen