search

artsy / eigen

The Art World in Your Pocket or Your Trendy Tech Company's Tote, Artsy's mobile app.
MIT License
3.54k stars 572 forks source link

fix: Filter out null notifications in Activity panel #10490

Closed olerichter00 closed 1 month ago

olerichter00 commented 1 month ago

The type of this PR is: Fix

This PR solves https://artsy.slack.com/archives/C05EQL4R5N0/p1721034091096429

Description

We should filter out null notifications in the Activity panel. This PR fixes the types of shouldDisplayNotification and adds a check that filters out null notifications to avoid the following error:

screenshot_2024-07-15_at_11 56 03_480

This PR solves https://artsy.slack.com/archives/C05EQL4R5N0/p1721034091096429

Description

We should filter out null notifications in the Activity panel. This PR fixes the types of shouldDisplayNotification and adds a check that filters out null notifications to avoid the following error:

screenshot_2024-07-15_at_11 56 03_480

ArtsyOpenSource commented 1 month ago
Warnings
:warning: ❌ **An error occurred while validating your changelog, please make sure you provided a valid changelog.**

Generated by :no_entry_sign: dangerJS against 0fae5732d70f4b897d509b36a67b7be4dbd253c2