artsy / eigen

The Art World in Your Pocket or Your Trendy Tech Company's Tote, Artsy's mobile app.
MIT License
3.54k stars 572 forks source link

feat(DIA-695): show profile prompt after sending an inquiry #10501

Closed iskounen closed 1 month ago

iskounen commented 1 month ago

This PR resolves DIA-695

Description

This PR updates the inquiry modal to prompt users to complete their profile after an inquiry is sent, if their profile is incomplete and they have not been prompted in 30 days.

I have observed a few issues with the Android implementation, which can be merged without impacting users since this is behind a feature flag:

  1. The modal flickers during autocompletion
  2. The submit button doesn't respond after selecting a new location
  3. The title of the location field is rendered behind its outline
  4. The modal overlay doesn't disappear after closing the modal
iOS Android
ios android

PR Checklist

To the reviewers 👀

Changelog updates ### Changelog updates #### Dev changes - Refactored inquiry modal to allow profile completion prompt - Added profile completion prompt behind a feature flag
ArtsyOpenSource commented 1 month ago

This PR contains the following changes:

araujobarret commented 1 month ago

about the PR title it should be type(ticket/element): description in this case feat(DIA-695): show profile...