Closed araujobarret closed 1 month ago
Generated by :no_entry_sign: dangerJS against fb3c54e099b55283bea5af52c51a67842b69e407
@MounirDhahri thanks a lot for the testing, https://github.com/artsy/eigen/pull/10506/commits/fb3c54e099b55283bea5af52c51a67842b69e407 addresses most of the changes you asked for(the critical one introduced by the tabs + the already existing UI paddings etc). The only one I couldn't reproduce on Android was the padding on the Rail π€ I think now it's in a better state to be batched with the release
https://github.com/user-attachments/assets/8711007d-d869-4e36-a50c-d47cde72e72f
https://github.com/user-attachments/assets/fb4eff1d-7c4a-40af-8bfb-fed2947bf22a
Description
This PR refactors the Fair and FairFollowedArtists screens, which the 1st was breaking on Android and supper laggy to incorporate the new Masonry element as a grid viewer. The refactoring on the 2nd screen was necessary because it used the fragment container from the 1st screen.
The 1st commit contains the refactor and the 2nd is the pulling of #10504 adapted to the refactor.
There are follow-ups to be made re polishing the UI, and some shifting happening around but we should prioritize shipping this boost, especially because of the crashes, and to work on them later.
Android
https://github.com/user-attachments/assets/e017d029-05e0-4f0f-a6e8-da8995ec08dbiPhone
https://github.com/user-attachments/assets/536d2637-f3a0-41da-9d87-01bbc9aa650ePR Checklist
To the reviewers π
Changelog updates
### Changelog updates #### Cross-platform user-facing changes - refactor: revamp Fair screen with Masonry and a better layout to support it - aruajobarret #### iOS user-facing changes - #### Android user-facing changes - #### Dev changes -Need help with something? Have a look at our docs, or get in touch with us.