refactor(Fair): Add Masonry to the Fair and FairFollowedArtists screen

araujobarret commented 1 month ago

Description

This PR refactors the Fair and FairFollowedArtists screens, which the 1st was breaking on Android and supper laggy to incorporate the new Masonry element as a grid viewer. The refactoring on the 2nd screen was necessary because it used the fragment container from the 1st screen.

The 1st commit contains the refactor and the 2nd is the pulling of #10504 adapted to the refactor.

There are follow-ups to be made re polishing the UI, and some shifting happening around but we should prioritize shipping this boost, especially because of the crashes, and to work on them later.

Android

https://github.com/user-attachments/assets/e017d029-05e0-4f0f-a6e8-da8995ec08db

iPhone

https://github.com/user-attachments/assets/536d2637-f3a0-41da-9d87-01bbc9aa650e

PR Checklist

[x] I have tested my changes on iOS and Android.
[x] I hid my changes behind a feature flag, or they don't need one.
[x] I have included screenshots or videos, or I have not changed the UI.
[x] I have added tests, or my changes don't require any.
[x] I added an app state migration, or my changes do not require one.
[x] I have documented any follow-up work that this PR will require, or it does not require any.
[x] I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

[ ] I would like at least one of the reviewers to run this PR on the simulator or device.

Changelog updates

### Changelog updates #### Cross-platform user-facing changes - refactor: revamp Fair screen with Masonry and a better layout to support it - aruajobarret #### iOS user-facing changes - #### Android user-facing changes - #### Dev changes -

Need help with something? Have a look at our docs, or get in touch with us.

ArtsyOpenSource commented 1 month ago

This PR contains the following changes:

Cross-platform user-facing changes (refactor: revamp Fair screen with Masonry and a better layout to support it - aruajobarret)
Generated by :no_entry_sign: dangerJS against fb3c54e099b55283bea5af52c51a67842b69e407

araujobarret commented 1 month ago

@MounirDhahri thanks a lot for the testing, https://github.com/artsy/eigen/pull/10506/commits/fb3c54e099b55283bea5af52c51a67842b69e407 addresses most of the changes you asked for(the critical one introduced by the tabs + the already existing UI paddings etc). The only one I couldn't reproduce on Android was the padding on the Rail 🤔 I think now it's in a better state to be batched with the release

https://github.com/user-attachments/assets/8711007d-d869-4e36-a50c-d47cde72e72f

https://github.com/user-attachments/assets/fb4eff1d-7c4a-40af-8bfb-fed2947bf22a

artsy / eigen