artsy / eigen

The Art World in Your Pocket or Your Trendy Tech Company's Tote, Artsy's mobile app.
MIT License
3.54k stars 572 forks source link

fix: issues with analytics not sending userID #10510

Closed brainbicycle closed 1 month ago

brainbicycle commented 1 month ago

This PR resolves PHIRE-1082

Description

We were initializing the segment client 2x - once in App.tsx and once in AppRegistry, the identify call was happening during auth flow so when segment client was reinitialized it blew away the saved user id. Seems only became a problem after the update to the analytics library.

PR Checklist

To the reviewers 👀

Changelog updates ### Changelog updates #### Cross-platform user-facing changes - #### iOS user-facing changes - #### Android user-facing changes - #### Dev changes - fix analytics not being tied to user ids - brian

Need help with something? Have a look at our docs, or get in touch with us.

ArtsyOpenSource commented 1 month ago

This PR contains the following changes: