[PURCHASE-1600] Hide 'contact gallery' button when artwork sale is closed

artsy / emission

⚠️ Deprecated repo, moved to artsy/eigen ➡️ React Native Components

http://artsy.github.io/blog/2018/04/17/making-a-components-pod/

MIT License

618 stars 78 forks source link

[PURCHASE-1600] Hide 'contact gallery' button when artwork sale is closed #1922

Closed sepans closed 5 years ago

sepans commented 5 years ago

Fixes PURCHASE-1600

Before:

After:

zephraph commented 5 years ago

I don't think the spacing with the button hidden is right. Between bidding closed and the Want to sell... copy seems like there's too much space.

sepans commented 5 years ago

Closing this in favor of https://github.com/artsy/emission/pull/1923

The spacing was complex so getting the spacing correct without the risk of breaking the layout of other screen variations was not possible so after discussing options with @zephraph decided to move the logic to the parent component to make sure neither the button no the spacer above it gets rendered