search

artsy / emission

⚠️ Deprecated repo, moved to artsy/eigen ➡️ React Native Components
http://artsy.github.io/blog/2018/04/17/making-a-components-pod/
MIT License
618 stars 78 forks source link

Fix text truncation for show titles in the Past Shows list on iphone #200

Open sarahscott opened 8 years ago

sarahscott commented 8 years ago

simulator screen shot jul 11 2016 1 18 58 pm

katarinabatina commented 8 years ago

also adjust spacing between each of these components, spacing between thumbnails and rules is uneven.

sarahscott commented 8 years ago

This one is a bit more complicated than the other text truncation issue; see: http://stackoverflow.com/questions/37936577/text-alignment-not-auto-justifying-in-react-native/37963314#37963314 http://stackoverflow.com/questions/36284453/react-native-text-going-off-my-screen-refusing-to-wrap-what-to-do https://github.com/facebook/react-native/issues/901

I am thinking the solution will involve some flexbox magic and I'm going to start on it after I finish some other things this week that are less minor.

mennenia commented 8 years ago

Ehh that's a shame :(.

Yeah looks like the textview actually extends on past the edge, so clipping doesn't respond, because it thinks there's space.