Closed xtina-starr closed 4 years ago
@xtina-starr I'm thinking about file structure for Collections and how we can maintain some order/organization around it that won't require complex refactors/moving around of files down the road.
I think Collections should follow the same organization and file naming conventions as the other components in Emission.
Can we re-name the files here to start with CollectionComponentName.tsx
and also move them to this folder src/lib/Scenes/Collection/Screens
e.g. src/lib/Scenes/Collection/Screens/CollectionFeaturedArtists.tsx
??
Since we already have CollectionHeader.tsx
and CollectionHeader.test.tsx
I'll make a small PR with the new file re-organization so it can be merged and any new development of Collection compents can be added to the src/lib/Scenes/Collection/Screens
directory.
Here's that PR! https://github.com/artsy/emission/pull/2006
Closing in favor of #2032, which rebased & moved this work forward.
Addresses: GROW-1423
This adds the featured artists component for the collections page in iOS. I wanted to get some feedback on what I have so far.