search

artsy / emission

⚠️ Deprecated repo, moved to artsy/eigen ➡️ React Native Components
http://artsy.github.io/blog/2018/04/17/making-a-components-pod/
MIT License
618 stars 78 forks source link

Points to our fork of tipsi-stripe #trivial #2004

Closed ashfurrow closed 4 years ago

ashfurrow commented 4 years ago

We need to point to point to our fork of tipsi-stripe because we pulled in this fix for this issue (it'll be included in an upcoming release of tipsi-stripe, so I'm fine still pointing to my own fork). Previously, we did this in Eigen, but was removed in the RN upgrade infrastructure PR:

https://github.com/artsy/eigen/pull/2962/files#diff-4a25b996826623c4a3a4910f47f10c30L101

This was causing the bug (app crashes when entering credit card number) to re-occur.

This adds it back, using that new infrastructure mechanism. I took a look at the other RN pods that we were pointing to forks on, and it appears all the changes we'd made are now included in their upstreams, so we're good to go 🙌

ashfurrow commented 4 years ago

Took off the MOG label to apply this change first:

https://github.com/ashfurrow/tipsi-stripe/commit/aeb742baf1a8329ba371d9c94c7650104a112807

We were pointing Yarn to my fork, but it was pointing CocoaPods back to the main source 😭 I verified the code change was included in the Objective-C this time (the bug doesn't present in the Emission Example app).

artsyit commented 4 years ago

:rocket: PR was released in v1.19.11 :rocket: