MX-117 Retry failed persisted queries with full text

artsy / emission

⚠️ Deprecated repo, moved to artsy/eigen ➡️ React Native Components

http://artsy.github.io/blog/2018/04/17/making-a-components-pod/

MIT License

618 stars 78 forks source link

MX-117 Retry failed persisted queries with full text #2007

Closed ds300 closed 4 years ago

ds300 commented 4 years ago

https://artsyproduct.atlassian.net/browse/MX-117

We often find that the beta builds fail to work on production because a query map update hasn't been deployed to metaphysics production yet.

This fixes that by retrying requests that failed due to a 404 on the query ID. On the retry request we pass the full query text to MP instead of the query ID.

Note that this won't help with query changes that depend on additions or fixes to MP.

I tested this on the artwork page.

ds300 commented 4 years ago

@ashfurrow great suggestion! It totally slipped my mind. 🍏

artsyit commented 4 years ago

:rocket: PR was released in v1.19.15 :rocket: