search

artsy / emission

⚠️ Deprecated repo, moved to artsy/eigen ➡️ React Native Components
http://artsy.github.io/blog/2018/04/17/making-a-components-pod/
MIT License
618 stars 78 forks source link

Updates Danger rule for adding tests for new files #2008

Closed ashfurrow closed 4 years ago

ashfurrow commented 4 years ago

I was reviewing #1999 and noticed the "skip new tests" hashtag to avoid the Danger rule. We've been doing that a lot, and it got me thinking about the purpose of the rule itself.

According to the comments in the Dangerfile, the rule is really intended only for new files, but modified files were being included in the check too. A comment above alludes to the fact that they're most interchangeable – but in my opinion, the check for new tests is not one of those times.

I've changed the Dangerfile to only check for new files, while leaving existing variables so that future rules can use them.

After merging this PR, the new-tests rule won't triggered spuriously, so we will all need to adjust our barometers for when it makes sense to add "skip new tests" to our PR descriptions 👍

artsyit commented 4 years ago

:rocket: PR was released in v1.19.13 :rocket: