search

artsy / emission

⚠️ Deprecated repo, moved to artsy/eigen ➡️ React Native Components
http://artsy.github.io/blog/2018/04/17/making-a-components-pod/
MIT License
618 stars 78 forks source link

[MX-70] - Guard against S3 upload crash #2018

Closed brainbicycle closed 4 years ago

brainbicycle commented 4 years ago

Show an error alert and allow retry rather than crash on unhandled JS Exception. Copy in screenshot is out of date - updated copy is: "Sorry, we couldn't upload your images." - (Removed optional s) "Please try again or contact consign@artsy.net for help."

The error alert looks like this: s3UploadErrorAlert

kierangillen commented 4 years ago

@brainbicycle This looks good to me! Good job!

artsyit commented 4 years ago

:rocket: PR was released in v1.20.4 :rocket: