search

artsy / emission

⚠️ Deprecated repo, moved to artsy/eigen ➡️ React Native Components
http://artsy.github.io/blog/2018/04/17/making-a-components-pod/
MIT License
618 stars 78 forks source link

Adds full bleed to collections header #2021

Closed ashleyjelks closed 4 years ago

ashleyjelks commented 4 years ago

Update the full-bleed method to return true enabling the collection header image to extend to the top of the iOS devices' viewport rather than being cut off by the status bar.

Links to QA Feedback Requested in GROW-1421

Screenshots with various collection headers below:

Screen Shot 2020-01-02 at 3 58 27 PM Screen Shot 2020-01-02 at 4 01 10 PM Screen Shot 2020-01-02 at 4 03 16 PM Screen Shot 2020-01-02 at 4 04 49 PM
sweir27 commented 4 years ago

I don't know much about this but based on other instances, this looks okay!

artsyit commented 4 years ago

:rocket: PR was released in v1.20.7 :rocket: