search

artsy / emission

⚠️ Deprecated repo, moved to artsy/eigen ➡️ React Native Components
http://artsy.github.io/blog/2018/04/17/making-a-components-pod/
MIT License
618 stars 78 forks source link

Excludes mocks from requiring their own unit tests #2028

Closed ashfurrow closed 4 years ago

ashfurrow commented 4 years ago

We're seeing a Danger failure in this PR because I added a new mock, and Danger is insisting we write a unit test for that mock: https://github.com/artsy/emission/pull/2027

It's expecting that src/lib/Scenes/Settings/__mocks__/LoggedInUserInfo.tsx has a corresponding src/lib/Scenes/Settings/__mocks__/__tests__/LoggedInUserInfo-tests.tsx test file. This update excludes mocks from the Danger rule.

EDIT: Forgot to say that I tested this change locally using DANGER_GITHUB_API_TOKEN=MY_PERSONAL_ACCESS_TOKEN yarn danger pr https://github.com/artsy/emission/pull/2027 and it works 👍

artsyit commented 4 years ago

:rocket: PR was released in v1.21.2 :rocket: