search

artsy / emission

⚠️ Deprecated repo, moved to artsy/eigen ➡️ React Native Components
http://artsy.github.io/blog/2018/04/17/making-a-components-pod/
MIT License
618 stars 78 forks source link

[FX-1716] Constrain collection's featured artists #2039

Closed anandaroop closed 4 years ago

anandaroop commented 4 years ago

https://artsyproduct.atlassian.net/browse/FX-1716

Paired with @pepopowitz on this.

When a collection definition includes a list of artist IDs, we don't want the Featured Artists in the header to stray beyond those artists.

This PR adds logic to constrain that list of Featured Artists, similarly to how the counterpart component in Reaction already does it.

In this example, from the Black Arts Movement collection (MP query), the Featured Artists would have included the non-requested artist Camille Billops, but will now correctly filter out that entry:

banda

I've also roughed in a Storybook story for Collections in this PR, as that seemed the most convenient way to sample a few different collections during development.

ashleyjelks commented 4 years ago

Looks good to me! Merge when ready!

artsyit commented 4 years ago

:rocket: PR was released in v1.21.9 :rocket: