artsy / emission

⚠️ Deprecated repo, moved to artsy/eigen ➡️ React Native Components
http://artsy.github.io/blog/2018/04/17/making-a-components-pod/
MIT License
618 stars 78 forks source link

Remove per-commit JS bundle options from Example app #2042

Closed ashfurrow closed 4 years ago

ashfurrow commented 4 years ago

Emission's Example app was originally intended to be used by PMs, designers, and stakeholders to see the absolute latest JS changes. The app could download the latest JS bundle, or a pull request bundle, or a commit bundle, from an S3 bucket.

The app hasn't been used like this for a while, for a few reasons:

We have a bunch of infrastructure to support this old way of doing things, but have already deprecated the Example app automatic deploys.

This PR removes infrastructure from the Example app to select a PR- or commit-specific JS bundle. It also removes the deploy job for these bundles (it was sending them to S3). Finally, it removes a Danger rule around the package.json native-code-version, which we relied upon to see if JS bundles were compatible with each other.

One more small step towards merging Eigen+Emission!

artsyit commented 4 years ago

:rocket: PR was released in v1.21.9 :rocket: