artsy / emission

⚠️ Deprecated repo, moved to artsy/eigen ➡️ React Native Components
http://artsy.github.io/blog/2018/04/17/making-a-components-pod/
MIT License
618 stars 78 forks source link

[MX-150] New search page analytics #2043

Closed ds300 closed 4 years ago

ds300 commented 4 years ago

https://artsyproduct.atlassian.net/browse/MX-150

This copies the previous behaviour, except we no longer have a "search screen closed" event because it's a tab now.

Worth noting that there are new subtleties which are not yet being taken into account (e.g. tapping on recent searches vs current search results). We can follow up with @anipetrov on how that should be represented.

anipetrov commented 4 years ago

left a few comments here https://artsyproduct.atlassian.net/browse/MX-150 -- will be easier to give more specific schema when i can play around with the new experience in the beta -- if i am not mistaken it's not yet in it, is it?

ashfurrow commented 4 years ago

That’s right – should be in the next beta!

artsyit commented 4 years ago

:rocket: PR was released in v1.21.10 :rocket: