search

artsy / emission

⚠️ Deprecated repo, moved to artsy/eigen ➡️ React Native Components
http://artsy.github.io/blog/2018/04/17/making-a-components-pod/
MIT License
618 stars 78 forks source link

Fixes bug causing image to fail to render in collection header #2045

Closed ashleyjelks closed 4 years ago

ashleyjelks commented 4 years ago

This PR fixes a bug where the collection header image URL was being reformated in Gemini both on the server and the client, thus creating an invalid URL.

Links to FX-1742

Screen Shot 2020-01-17 at 3 23 03 PM
artsyit commented 4 years ago

:rocket: PR was released in v1.21.11 :rocket:

ashleyjelks commented 4 years ago

👍

My understanding of this change is that we will no longer try to fetch a resized image. I'll merge this change, but should there be follow-up work to make it work with resized images? It seems like it would be a potential issue after launch if we are pulling in large images.

The image is resized in Metaphysics so we don't need to do the resize a 2nd time in Emission. That boolean useRawURL is what prevents the image component from requesting a resized url from Gemini on the client side. See OpaqueImageView.