search

artsy / emission

⚠️ Deprecated repo, moved to artsy/eigen ➡️ React Native Components
http://artsy.github.io/blog/2018/04/17/making-a-components-pod/
MIT License
618 stars 78 forks source link

Follow artist #2054

Closed ashleyjelks closed 4 years ago

ashleyjelks commented 4 years ago

This PR adds the support to and handle mutations to follow/unfollow artists in the Collections featured artist component.

Kapture 2020-01-23 at 12 48 09

https://artsyproduct.atlassian.net/browse/FX-1659

pepopowitz commented 4 years ago

Per a slack conversation, @sweir27 pointed out that there's an existing component we could use instead of generating each artist item ourselves. I think we should leave this PR open but mark it "do not merge", until we're certain that reusing the ArtistListItem component works.

Thoughts?

ashleyjelks commented 4 years ago

Per a slack conversation, @sweir27 pointed out that there's an existing component we could use instead of generating each artist item ourselves. I think we should leave this PR open but mark it "do not merge", until we're certain that reusing the ArtistListItem component works.

Thoughts?

Sounds good to me! We'll need to make a new ticket reflect this migration work. Also, there's a small change to resize the header image that needs to be put into a separate PR. I will make that change now as well since we likely won't be merging this one.