search

artsy / emission

⚠️ Deprecated repo, moved to artsy/eigen ➡️ React Native Components
http://artsy.github.io/blog/2018/04/17/making-a-components-pod/
MIT License
618 stars 78 forks source link

[FX-1750] Use explicit size param for collection header's featured artists #2057

Closed anandaroop closed 4 years ago

anandaroop commented 4 years ago

https://artsyproduct.atlassian.net/browse/FX-1750

Follow-up to https://github.com/artsy/metaphysics/pull/2130

This uses the new size param on the artworksConnection.merchandisableArtists field to limit the number of featured artists returned in the collection header:

change

EDIT: Lol I just realized the two images here are swapped (or the arrow should be reversed)

Didn't add a test because there's no change in behavior in the component itself, only in the data fetched by the container.

ashleyjelks commented 4 years ago

LGTM! Merge when ready!

artsyit commented 4 years ago

:rocket: PR was released in v1.21.22 :rocket: