[FX-1747] Refactor FeatureArtist component to use ArtistListItem component

artsy / emission

⚠️ Deprecated repo, moved to artsy/eigen ➡️ React Native Components

http://artsy.github.io/blog/2018/04/17/making-a-components-pod/

MIT License

618 stars 78 forks source link

[FX-1747] Refactor FeatureArtist component to use ArtistListItem component #2059

Closed xtina-starr closed 4 years ago

xtina-starr commented 4 years ago

This PR addresses https://artsyproduct.atlassian.net/browse/FX-1747. It refactors the FeaturedArtists component to use the ArtistListItem component. When we originally built FeaturedArtists, we weren't aware of ArtistListItem, which already has all of the features we need.

Follow Functionality: FeaturedArtist

Analytics Tracking for follow/unfollow

pepopowitz commented 4 years ago

@xtina-starr I think this PR is code-complete! I removed the WIP and added a bit more context to the description.

ashleyjelks commented 4 years ago

Just a minor question, also could we get attach a video shot confirming that the follow/unfollow mutations are working as expected (including views of the artist page showing the Follow state changes after interacting with the Follow button from the collections screen)?

ashleyjelks commented 4 years ago

I think this is good to merge after the conflict are resolved!

artsyit commented 4 years ago

:rocket: PR was released in v1.21.28 :rocket: