Fixes issue with Artist tracking components #trivial

artsy / emission

⚠️ Deprecated repo, moved to artsy/eigen ➡️ React Native Components

http://artsy.github.io/blog/2018/04/17/making-a-components-pod/

MIT License

618 stars 78 forks source link

Fixes issue with Artist tracking components #trivial #2062

Closed ashfurrow closed 4 years ago

ashfurrow commented 4 years ago

This is a follow-up to https://github.com/artsy/emission/pull/2058 . Without decorating the top-level component with either @screenTrack() (which generates tracking events itself) or @track() (which exposes the tracking capabilities to the component tree, but doesn't itself track events), then the component tree will fail to render. I've verified this still keeps fixes the duplicate artist screen tracks 👍

Going to self-merge so we have a workable beta for the weekend.

artsyit commented 4 years ago

:rocket: PR was released in v1.21.23 :rocket: