search

artsy / emission

⚠️ Deprecated repo, moved to artsy/eigen ➡️ React Native Components
http://artsy.github.io/blog/2018/04/17/making-a-components-pod/
MIT License
618 stars 78 forks source link

[FX-1787] Use a larger base image for collection header #2077

Closed pepopowitz closed 4 years ago

pepopowitz commented 4 years ago

A collaboration with @ashleyjelks.

Addresses https://artsyproduct.atlassian.net/browse/FX-1787.

Some collections were showing pixelated header images - especially those whose first artwork had a portrait aspect ratio. We identified that we were using the medium-sized image as a basis for our image resizing, which resulted in the pixelation.

In this PR we change the query to request the larger-sized image as a basis for image resizing. This results in higher quality header images for all collections, but especially the ones that were previously pixelated.

We verified that if an artwork does not have a larger-sized image, it would fall back to medium without us having to do anything.

Before this change:

image

After this change:

image

artsyit commented 4 years ago

:rocket: PR was released in v1.21.36 :rocket: