Preserve changes made manually to the MP query map

artsy / emission

⚠️ Deprecated repo, moved to artsy/eigen ➡️ React Native Components

http://artsy.github.io/blog/2018/04/17/making-a-components-pod/

MIT License

618 stars 78 forks source link

Preserve changes made manually to the MP query map #2078

Closed ds300 closed 4 years ago

ds300 commented 4 years ago

yesterday we needed to manually edit an existing query in MP's persisted query map. Unfortunately after deploying emission it overwrote that manual change because that's how emission updates the MP query map during it's deploy job on CI.

here we change the logic so that it preserves the MP version as the source of truth.

see artsy/metaphysics#2160 #2075 and https://artsy.slack.com/archives/CN8S32FJR/p1581001886215700 for context

ashfurrow commented 4 years ago

Travis is 🍏 but hasn't reported back yet. Merging.

artsyit commented 4 years ago

:rocket: PR was released in v1.21.38 :rocket: