Closed anandaroop closed 4 years ago
https://artsyproduct.atlassian.net/browse/FX-1748
This simply updates ReadMore to use font size 3 instead of 3t (i.e. the tightly-spaced variant)
ReadMore
3
3t
I was curious why this component was spec'd with 3t size to begin with, so I did the Github and Jira archaeology to find:
https://github.com/artsy/emission/pull/1654, which implements:
https://artsyproduct.atlassian.net/browse/PURCHASE-1139, which includes the comp:
https://app.zeplin.io/project/5ab94282c124db8d58365b47/screen/5cdb43f2b4655d1e7436ca1a
From there I can see that this component was 16/24 serif which does in fact map to size 3
I figure this was an oversight that just persisted till now, so I think this change should be good to go, and @jeffreytr agrees!
Great find!
:rocket: PR was released in v1.21.41 :rocket:
https://artsyproduct.atlassian.net/browse/FX-1748
This simply updates
ReadMore
to use font size3
instead of3t
(i.e. the tightly-spaced variant)Phone
Tablet
Background
I was curious why this component was spec'd with
3t
size to begin with, so I did the Github and Jira archaeology to find:https://github.com/artsy/emission/pull/1654, which implements:
https://artsyproduct.atlassian.net/browse/PURCHASE-1139, which includes the comp:
https://app.zeplin.io/project/5ab94282c124db8d58365b47/screen/5cdb43f2b4655d1e7436ca1a
From there I can see that this component was 16/24 serif which does in fact map to size 3
I figure this was an oversight that just persisted till now, so I think this change should be good to go, and @jeffreytr agrees!