artsy / emission

⚠️ Deprecated repo, moved to artsy/eigen ➡️ React Native Components
http://artsy.github.io/blog/2018/04/17/making-a-components-pod/
MIT License
618 stars 78 forks source link

[FX-1748] Fix line-height in ReadMore component #2081

Closed anandaroop closed 4 years ago

anandaroop commented 4 years ago

https://artsyproduct.atlassian.net/browse/FX-1748

This simply updates ReadMore to use font size 3 instead of 3t (i.e. the tightly-spaced variant)

Phone

banda

Tablet

ipadbanda

Background

I was curious why this component was spec'd with 3t size to begin with, so I did the Github and Jira archaeology to find:

From there I can see that this component was 16/24 serif which does in fact map to size 3

I figure this was an oversight that just persisted till now, so I think this change should be good to go, and @jeffreytr agrees!

ashleyjelks commented 4 years ago

Great find!

artsyit commented 4 years ago

:rocket: PR was released in v1.21.41 :rocket: