search

artsy / emission

⚠️ Deprecated repo, moved to artsy/eigen ➡️ React Native Components
http://artsy.github.io/blog/2018/04/17/making-a-components-pod/
MIT License
618 stars 78 forks source link

WIP Adds Navigation Stack to Sort Collection Artworks #2089

Closed ashleyjelks closed 4 years ago

ashleyjelks commented 4 years ago

https://artsyproduct.atlassian.net/browse/FX-1593

ArtsyOpenSource commented 4 years ago
Fails
:no_entry_sign: 🃏 FAIL in FilterModal-tests.tsx
  • renders a snapshot of the filter artworks modal
    Snapshot name: `renders a snapshot of the filter artworks modal 1`- Snapshot+ Received@@ -46,15 +46,10 @@ "backgroundColor": "white", "borderTopLeftRadius": 10, "borderTopRightRadius": 10, "flexDirection": "column", "height": 0,- "paddingBottom": 0,- "paddingLeft": 0,- "paddingRight": 0,- "paddingTop": 0,- "width": "100%", }, ] } visible={false} >@@ -85,14 +80,19 @@ }, ] } > @@ -240,353 +242,1843 @@ Clear all - + + + + + + + Sort by+ + + + Default+ + + + + + + + + + + + + + + + + Ways to buy+ + + + All+ + + + + + + + + + + + + + + + + Medium+ + + + All+ + + + + + + + + + + + + + + + + Price range+ + + + All+ + + + + + + + + + + + + + + + + Size+ + + + All+ + + + + + + + + + + + + + + + + Time period+ + + + All+ + + + + + + + + + + + + + + + + + - + + + Ok+ + Ok - - Ok-
    Full message 
    
Error: expect(received).toMatchSnapshot()

Snapshot name: `renders a snapshot of the filter artworks modal 1`

- Snapshot
+ Received

@@ -46,15 +46,10 @@
              "backgroundColor": "white",
              "borderTopLeftRadius": 10,
              "borderTopRightRadius": 10,
              "flexDirection": "column",
              "height": 0,
-             "paddingBottom": 0,
-             "paddingLeft": 0,
-             "paddingRight": 0,
-             "paddingTop": 0,
-             "width": "100%",
            },
          ]
        }
        visible={false}
      >
@@ -85,14 +80,19 @@
                },
              ]
            }
          >
            
              
          
@@ -240,353 +242,1843 @@
          
          
            Clear all
          
        
        
-         
+           
+             
+               
+                 
+                   
+                     
+                       Sort by
+                     
+                     
+                       
+                         Default
+                       
+                       
+                         
+                           
+                         
+                       
+                     
+                   
+                 
+               
+             
+             
+               
+                 
+                   
+                     
+                       Ways to buy
+                     
+                     
+                       
+                         All
+                       
+                       
+                         
+                           
+                         
+                       
+                     
+                   
+                 
+               
+             
+             
+               
+                 
+                   
+                     
+                       Medium
+                     
+                     
+                       
+                         All
+                       
+                       
+                         
+                           
+                         
+                       
+                     
+                   
+                 
+               
+             
+             
+               
+                 
+                   
+                     
+                       Price range
+                     
+                     
+                       
+                         All
+                       
+                       
+                         
+                           
+                         
+                       
+                     
+                   
+                 
+               
+             
+             
+               
+                 
+                   
+                     
+                       Size
+                     
+                     
+                       
+                         All
+                       
+                       
+                         
+                           
+                         
+                       
+                     
+                   
+                 
+               
+             
+             
+               
+                 
+                   
+                     
+                       Time period
+                     
+                     
+                       
+                         All
+                       
+                       
+                         
+                           
+                         
+                       
+                     
+                   
+                 
+               
+             
+             
+           
+         
+       
+       
+         
+           
-           
+             
+               
+                 Ok
+               
+             
              
                Ok
              
            
-           
-             Ok
-           
          
        
      
    
  
    at Object.toMatchSnapshot (/home/travis/build/artsy/emission/src/lib/Components/__tests__/FilterModal-tests.tsx:21:16)
    at Object.asyncJestTest (/home/travis/build/artsy/emission/node_modules/jest-jasmine2/build/jasmineAsyncInstall.js:102:37)
    at /home/travis/build/artsy/emission/node_modules/jest-jasmine2/build/queueRunner.js:43:12
    at new Promise ()
    at mapper (/home/travis/build/artsy/emission/node_modules/jest-jasmine2/build/queueRunner.js:26:19)
    at /home/travis/build/artsy/emission/node_modules/jest-jasmine2/build/queueRunner.js:73:41

    • :no_entry_sign: Missing Test Files: - `src/lib/data/__tests__/ArtworkFilterOptions-tests.ts` If these files are supposed to not exist, please update your PR body to include "#skip_new_tests".

    Generated by :no_entry_sign: dangerJS