search

artsy / emission

⚠️ Deprecated repo, moved to artsy/eigen ➡️ React Native Components
http://artsy.github.io/blog/2018/04/17/making-a-components-pod/
MIT License
618 stars 78 forks source link

Enables incremental compiler option #trivial #2093

Closed ashfurrow closed 4 years ago

ashfurrow commented 4 years ago

@damassi brought this up on Slack and it seems like a great idea: https://artsy.slack.com/archives/C02BC3HEJ/p1581803473357200

ds300 commented 4 years ago

This unfortunately won't affect us because we use tsc with the noEmit option :(((

See here for details: https://github.com/microsoft/TypeScript/issues/30661

The only workaround people have found so far is to turn off noEmit and dump the compiler output somewhere out-of-the-way.

For me, tsc runs in 10s and pretty much only ever as part of the prepush hook, so I don't mind putting up with this until the TS team finds a solution. Maybe we can nudge our friend on the inside? 🙊

If this is a big deal for other devs then I'm onboard to try out the workaround. What do you think?

ashfurrow commented 4 years ago

Gotcha, thanks for that context @ds300 👍 Orta is focused on the TypeScript website at the moment, and based on how the TS team is structured, I don't think we'd be able to nudge the team very far right now.

This wasn't a big deal for me, it only seemed like a quick win. I'm fine closing – thanks for the context! 🙏