artsy / emission

⚠️ Deprecated repo, moved to artsy/eigen ➡️ React Native Components
http://artsy.github.io/blog/2018/04/17/making-a-components-pod/
MIT License
618 stars 78 forks source link

[FX-1735] Featured artist view #2098

Closed xtina-starr closed 4 years ago

xtina-starr commented 4 years ago

Addresses: FX-1735

Issue: When there are several featured artists within a collection and a user clicks the "View more" link, the featured artist module pushes the content beneath the featured artist module down making it not visible to the user.

Fix: This PR refactors the featured artist component to take the user to a new view when the "View all" link is clicked. This displays all the artists that are within the collection and gives the user a back button to navigate back to the collection.

featured artists list

Remaining work:

ashleyjelks commented 4 years ago

Looks good!!! 🎉 Nice work.

Re: tests, it would be good to verify that the FullFeaturedArtistListComponent correctly excludes artistIDs and FeaturedArtistIDs where applicable! 😄

It doesn't seem like we need a feature flag for this, as there won't be any follow-up work and it doesn't seem risky to ship directly to users. What do you think?

I agree about the feature flag suggestion. I think this is something Jeffrey wanted to see fixed sooner rather than later as well, but wouldn't hurt to double-check with him to confirm!

xtina-starr commented 4 years ago

Closing this PR in favor of https://github.com/artsy/eigen/pull/3039