artsy / force

The Artsy.net website
https://www.artsy.net
MIT License
601 stars 152 forks source link

Search results are based on last autocomplete result rather than actual query input #1041

Open joeyAghion opened 7 years ago

joeyAghion commented 7 years ago

When I type into the search field and hit return, I frequently see results for some prefix of what I actually entered. My initial sense is that navigation to the search results page uses the completed autocomplete query rather than what I've actually typed into the field. If I type at a good speed, I'll end up hitting return before the final autocomplete response. (When I type more slowly and wait for the autocomplete response, the results match my input.)

mzikherman commented 7 years ago

I can't really reproduce this, typing 'picasso' at differing rates of speed and hitting 'Enter' seem to work fine.

Also looking at the code, it's just a form submission so I'm not sure how/why the autocompletes would mess with that. Feel free to reopen!

joeyAghion commented 7 years ago

Maybe because it's cached?

You can see what I'm talking about in the final search here:

2017-05-01_fast_artsy_search2

mzikherman commented 7 years ago

Still can't repro that locally even following along to your gif!