artsy / force

The Artsy.net website
https://www.artsy.net
MIT License
599 stars 152 forks source link

fix: ensure proxy *can* be disabled gracefully (DIA-818) #14422

Closed joeyAghion closed 2 months ago

joeyAghion commented 2 months ago

We noticed while experimenting with edge-caching that already-loaded Force sessions begin erroring if the proxy is disabled server-side. That's because the endpoint targeted by existing clients starts to respond with 404s. Instead, let's continue to support the proxy route even if the proxy is disabled. Freshly loaded pages will target un-proxied Metaphysics, while existing pages should continue to operate.

mzikherman commented 2 months ago

Nice - makes sense to me.

relativeci[bot] commented 2 months ago

#152 Bundle Size — 9.51MiB (~-0.01%).

6093bab(current) vs 3903bc9 main#151(baseline)

[!WARNING] Bundle contains 45 duplicate packages – View duplicate packages

Bundle metrics  Change 1 change Improvement 1 improvement
                 Current
#152
     Baseline
#151
Improvement  Initial JS 4.32MiB(~-0.01%) 4.32MiB
No change  Initial CSS 0B 0B
No change  Cache Invalidation 3.19% 3.19%
No change  Chunks 142 142
No change  Assets 145 145
No change  Modules 5551 5551
No change  Duplicate Modules 380 380
No change  Duplicate Code 4.78% 4.78%
No change  Packages 292 292
No change  Duplicate Packages 42 42

Bundle size by type  Change 1 change Improvement 1 improvement
|            |       Current
[#152](https://app.relative-ci.com/projects/zNeNymVCPwxxOLTcM9qt/jobs/152-f8zdbwGFKeoNMm42NlsG?utm_source=github&utm_medium=pr-report "View bundle analysis report") |      Baseline
[#151](https://app.relative-ci.com/projects/zNeNymVCPwxxOLTcM9qt/jobs/151-C6mnUWwmk3slyOSQri0p?utm_source=github&utm_medium=pr-report "View baseline bundle analysis report") | |:--|--:|--:| | Improvement  [JS](https://app.relative-ci.com/projects/zNeNymVCPwxxOLTcM9qt/jobs/152-f8zdbwGFKeoNMm42NlsG/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-1_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-0%22%7D "View JS assets") | `9.3MiB` (`~-0.01%`) | `9.3MiB` | | No change  [Other](https://app.relative-ci.com/projects/zNeNymVCPwxxOLTcM9qt/jobs/152-f8zdbwGFKeoNMm42NlsG/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-1%22%7D "View Other assets") | `213.94KiB` | `213.94KiB` |

Bundle analysis reportBranch joeyAghion/proxyProject dashboard


Generated by RelativeCIDocumentationReport issue