artsy / garner

A set of Rack middleware and cache helpers that implement various caching strategies.
MIT License
343 stars 24 forks source link

Add whiny_nils configuration variable to control behavior on nil bindings #70

Closed fancyremarker closed 10 years ago

fancyremarker commented 10 years ago

The use case is that sometimes I want to be able to call garner.bind(something) { } where something may be nil. The result won't be cached, but it also won't raise an exception. I set the configuration variable to default to the old behavior.

fancyremarker commented 10 years ago

Oh, also pinned rspec and mongoid in the development dependencies because Garner doesn't work with RSpec 3.x or Mongoid 4.x.

dblock commented 10 years ago

Garner works fine with Mongoid 4. I'll take a look at the specs, https://github.com/artsy/garner/issues/71.

dblock commented 10 years ago

You need to document this in the README, too.

fancyremarker commented 10 years ago

Rebased and addressed the following issues:

Did not address the Mongoid 3.x development dependency issue since we can do that on #71.

dblock commented 10 years ago

Perfect, merging.