artsy / metaphysics

Artsy's GraphQL API
MIT License
360 stars 89 forks source link

feat: remove legacy Invoice type/schema under Conversation #6135

Closed mzikherman closed 4 weeks ago

mzikherman commented 4 weeks ago

In preparation for adding invoice/invoice payment stuff to Metaphysics so that we can rebuild Charge (and thus we need Invoice support in our schema) - found this very legacy different Invoice type under a conversation (referencing a system named Lewitt).

Searching Metaphysics traces in Datadog for 'invoice' over the last 3 months reveals zero queries that included that string, so seems safe to delete! These were very old.

We'll be able to add our more modern Invoice-named type.

mzikherman commented 4 weeks ago

(gonna selfie-merge so this can get the updated schema pushed out to Force and Eigen to ensure those updates can get seamlessly merged)

jonallured commented 4 weeks ago

Oh wow Lewitt!!

https://github.com/artsy/lewitt-api https://github.com/artsy/lewitt-web-public